Improve bug! message for impossible case in Relate #54679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hitting this branch in Clippy and I think it makes sense to print both values here in case other people hit this branch, too.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
@tmandry: 🔑 Insufficient privileges: Not in reviewers |
|
Looks like bors hasn’t updated yet, you’re the first PR I tried to r+ |
|
@bors r+ |
|
📌 Commit d654e3c has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 1, 2018
…hewjasper Improve bug! message for impossible case in Relate Hitting this branch [in Clippy][clippy_issue] and I think it makes sense to print both values here in case other people hit this branch, too. (still have to figure out why this branch is hit) [clippy_issue]: rust-lang/rust-clippy#2831 (comment)
bors
added a commit
that referenced
this pull request
Oct 1, 2018
Rollup of 13 pull requests Successful merges: - #53784 (Document that slices cannot be larger than `isize::MAX` bytes) - #54308 (Better user experience when attempting to call associated functions with dot notation) - #54488 (in which we include attributes in unused `extern crate` suggestion spans) - #54544 (Indicate how to move value out of Box in docs.) - #54623 (Added help message for `impl_trait_in_bindings` feature gate) - #54641 (A few cleanups and minor improvements to rustc/infer) - #54656 (Correct doc for WorkQueue<T>::pop().) - #54674 (update miri) - #54676 (Remove `-Z disable_ast_check_for_mutation_in_guard`) - #54679 (Improve bug! message for impossible case in Relate) - #54681 (Rename sanitizer runtime libraries on OSX) - #54708 (Make ./x.py help <cmd> invoke ./x.py <cmd> -h on its own) - #54713 (Add nightly check for tool_lints warning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitting this branch in Clippy and I think it makes sense to print
both values here in case other people hit this branch, too.
(still have to figure out why this branch is hit)